feat: Add ApiEnum and apiEnumValueOfOrNull helper methods #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we write enums with PascalCase we can't always use the `enumValueOfOrNull` and base the recognition on the name of the enum value. So I added a helper method to easily get an enum instance for any enum that extends the ApiEnum interface. The interface only requires the children to implement an `apiValue` field that will be used to match the input string. The helper method is pretty similar to the existing `enumValueOfOrNull` but with a different name. Downgrading androidxCore was necessary to use the module on Mail for the time being.
|
tevincent
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we write enums with PascalCase we can't always use the
enumValueOfOrNulland base the recognition on the name of the enum value. So I added a helper method to easily get an enum instance for any enum that extends the ApiEnum interface. The interface only requires the children to implement anapiValuefield that will be used to match the input string. The helper method is pretty similar to the existingenumValueOfOrNullbut with a different name.Downgrading androidxCore was necessary to use the module on Mail for the time being.